Emil Velikov <emil.l.veli...@gmail.com> writes: > On 21/04/15 14:04, Francisco Jerez wrote: >> EdB <edb+m...@sigluy.net> writes: >> >>> Later we can remove the compat code >>> >>> According to Francisco Jerez, it happen that some time llvm requiring exotic >>> compilation flags and it would be preferable not to to contaminate the rest >>> of >>> the clover build and keep the 3 statics libs >> >> Not terribly informative... Without this paragraph, >> Reviewed-by: Francisco Jerez <curroje...@riseup.net> >> > I don't know the gory details of LLVM_CXXFLAGS, like a few others, so it > is quite informative actually :-) > Sorry, but I feel it's inaccurate, irrelevant to this commit, and not even grammatical. IMHO it creates more confusion than no comment at all.
> libclllvm aside, what is stopping us from merging libclover and libcltgsi ? > No important reason other than symmetry. > Thanks > Emil > >>> --- >>> src/gallium/state_trackers/clover/Makefile.am | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/src/gallium/state_trackers/clover/Makefile.am >>> b/src/gallium/state_trackers/clover/Makefile.am >>> index 62c13fa..f46d9ef 100644 >>> --- a/src/gallium/state_trackers/clover/Makefile.am >>> +++ b/src/gallium/state_trackers/clover/Makefile.am >>> @@ -35,12 +35,13 @@ endif >>> noinst_LTLIBRARIES = libclover.la libcltgsi.la libclllvm.la >>> >>> libcltgsi_la_CXXFLAGS = \ >>> - -std=c++0x \ >>> + -std=c++11 \ >>> $(VISIBILITY_CXXFLAGS) >>> >>> libcltgsi_la_SOURCES = $(TGSI_SOURCES) >>> >>> libclllvm_la_CXXFLAGS = \ >>> + -std=c++11 \ >>> $(VISIBILITY_CXXFLAGS) \ >>> $(LLVM_CXXFLAGS) \ >>> $(DEFINES) \ >>> -- >>> 2.4.0.rc2 >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> mesa-dev@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev >>> >>> >>> _______________________________________________ >>> mesa-dev mailing list >>> mesa-dev@lists.freedesktop.org >>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
signature.asc
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
