On Fri, Mar 13, 2015 at 04:26:28PM +0000, Neil Roberts wrote: > The render surface state command for Skylake doesn't have the surface > array spacing bit so it's not possible to select this layout. I think > it was only used in order to make it pick a tightly-packed qpitch > value that doesn't include space for the mipmaps. However this won't > be necessary after the next patch because it will automatically pick a > packed qpitch value whenever first_level==last_level. It is better to > remove this layout entirely on Gen8+ because although it can > effectively be implemented with a small qpitch value when there are no > mipmaps it isn't possible to support the case where there are mipmaps > because in that case the layout is very different. > > It could be good to make a similar change for Gen8 if we also change > the layouting code to pick the qpitch value in a similar way. > > v2: Make the commit message and comments more convincing
Yell louder next time, I think you just fixed my fast clear bugs :D !!! Reviewed-by: Ben Widawsky <b...@bwidawsk.net> Tested-by: Ben Widawsky <b...@bwidawsk.net> _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
