On Fri, Apr 03 2015, Jordan Justen wrote: >> - (fill-column . 78) > > Do we want to remove this? Or does it match the default?
The default is actually 70. I didn't mean to have that part in the
commit. Thanks for noticing.
>> + (".git" (nil (fill-column . 70)))
>
> Should the commit subject line be under 70 characters? I notice that
> yours is 74. :)
Right. I don't use auto-fill, and I don't always hit the fill-paragraph
key if I'm only typing a single line.
> https://www.kernel.org/doc/Documentation/SubmittingPatches says the
> subject line should be limited to 70-75 characters.
Phew! I at least fit within the kernel guideline.
> Maybe the .git part should be moved that into a separate patch?
I thought about that, but in one sense, all of this mucking around with
trying to get emacs to behave in a sane way is somewhat off-topic for
mesa, so I thought keeping it in just one commit was more polite.
> Not a huge deal though, so,
> Reviewed-by: Jordan Justen <jordan.l.jus...@intel.com>
Thanks.
-Carl
pgpkwl9DXKwgq.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
