On Mar 26, 2015 6:58 PM, "Matt Turner" <matts...@gmail.com> wrote: > > On Thu, Mar 26, 2015 at 1:35 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > > What about other datatypes such as D or UW? Perhaps we should have > > some sort of is_integer function and just do is_integer(a) != > > is_integer(b)? > > I can't come up with any case where we'd be doing a partial write > (with B/UB/W/UW types) and then comparing that. I don't think that's > possible. > > Your question about D though -- that's fine. The check is "if the > types aren't the same, and one is a float".
We could still have a problem with doubles or half-float. Probably worth at least a fixme comment. Other than that. Reviewed-by: Jason Ekstrand <jason.ekstr...@intel.com>
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
