With the fix Jason mentioned: Reviewed-by: Chris Forbes <chr...@ijw.co.nz>
On Wed, Mar 18, 2015 at 10:19 AM, Matt Turner <matts...@gmail.com> wrote: > On Tue, Mar 17, 2015 at 2:15 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: >> On Tue, Mar 17, 2015 at 2:09 PM, Matt Turner <matts...@gmail.com> wrote: >>> diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp >>> b/src/mesa/drivers/dri/i965/brw_vec4.cpp >>> index 8edb4d0..63dedae 100644 >>> --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp >>> +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp >>> @@ -1969,7 +1969,7 @@ brw_vs_emit(struct brw_context *brw, >>> } >>> >>> fs_generator g(brw, mem_ctx, (void *) &c->key, &prog_data->base.base, >>> - &c->vp->program.Base, v.runtime_check_aads_emit, >>> "VS"); >>> + &c->vp->program.Base, v.runtime_check_aads_emit, >>> v.promoted_constants, "VS"); >> >> Promoted constants and aads_emit need to be flipped around. You got >> it right for FS. > > Thanks! > >> Also, does this require any adaptations to shader-db or does it work as-is? > > Works as is, but shader-db report.py doesn't know about the new > things. I'd like to add some switches to it like --spills or > --compaction and have it print stats based on those. > >> Other than that, >> Reviewed-by: Jason Ekstrand <jason.ekstr...@intel.com> > > Thanks! > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
