On 03/10/2015 08:47 PM, Ian Romanick wrote:
On 03/10/2015 07:47 PM, Ian Romanick wrote:
On 03/10/2015 06:42 PM, Brian Paul wrote:
We were already using strdup() in various places in Mesa. Get rid
of the _mesa_strdup() wrapper. All the callers pass a non-NULL
argument so the NULL check isn't needed either.
---
src/mesa/main/imports.c | 18 ------------------
src/mesa/main/imports.h | 3 ---
src/mesa/main/objectlabel.c | 2 +-
src/mesa/main/shaderapi.c | 2 +-
src/mesa/main/transformfeedback.c | 2 +-
src/mesa/program/prog_instruction.c | 2 +-
src/mesa/program/prog_parameter.c | 2 +-
src/mesa/program/prog_statevars.c | 2 +-
src/mesa/program/program.c | 6 +++---
A quick 'grep -lr _mesa_strdup src/ | sort' shows the following files:
src/gallium/state_trackers/glx/xlib/glx_api.c
src/mesa/drivers/x11/fakeglx.c
src/mesa/main/imports.c
src/mesa/main/imports.h
src/mesa/main/objectlabel.c
src/mesa/main/shaderapi.c
src/mesa/main/transformfeedback.c
src/mesa/program/prog_instruction.c
src/mesa/program/prog_parameter.c
src/mesa/program/program.c
src/mesa/program/prog_statevars.c
It looks like you missed a couple:
src/gallium/state_trackers/glx/xlib/glx_api.c
src/mesa/drivers/x11/fakeglx.c
But I guess patch 1 got the first one.
I missed a patch when I mailed this series to the list. I'll post it
shortly.
-Brian
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
