Kenneth Graunke <kenn...@whitecape.org> writes:

> Generated by the following Coccinelle semantic patch:
>
> @@
> expression E;
> @@
> if (
> -E
> +unlikely(E)
>  )
> { ... _mesa_error(...) ... }
>
> Improves performance in OglBatch7 (a CPU-bound microbenchmark) on
> an i7 4750HQ (Haswell) by 1.08546% +/- 0.519734% (n=292).
>
> Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>

Neat!

I think you're supposed to be able to get the same result by marking
_mesa_error as attribute cold.  Then nobody can forget to mark their
conditions as unlikely in the future.

Attachment: signature.asc
Description: PGP signature

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to