On Fri, Feb 20, 2015 at 3:07 PM, Ilia Mirkin <imir...@alum.mit.edu> wrote:
> On Thu, Feb 19, 2015 at 9:59 PM, Glenn Kennard <glenn.kenn...@gmail.com>
> wrote:
>>> + if ((write_mask & 0x3) != 0x3 &&
>>> + (write_mask & 0xc) != 0xc) {
>>> + fprintf(stderr, "illegal writemask for 64-bit: 0x%x\n",
>>> write_mask);
>>> + return -1;
>>> + }
>
> I think I noted this on IRC, but did you mean this to be || instead of
> && ? e.g. right now this will not trigger for a .xyz writemask, since
> write_mask & 3 == 3.
Oh but it can't be || either, since write_mask == 3 should pass this.
I guess you want like
if (write_mask & 3 && write_mask & 3 != 3)
error
if (writemask & c && writemaks & c != c)
error
-ilia
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
