https://bugs.freedesktop.org/show_bug.cgi?id=88907
--- Comment #4 from Ian Romanick <i...@freedesktop.org> ---
(In reply to Ian Romanick from comment #3)
> Comment on attachment 113390 [details] [review]
> patch to fix the issue
>
> Review of attachment 113390 [details] [review]:
> -----------------------------------------------------------------
>
> I think the problem is that adjust_for_oes_float_texture is called even when
> internalFormat is not GL_FLOAT, GL_HALF_FLOAT_OES, or GL_HALF_FLOAT.
>
> It seems like this would be better:
>
> if (_mesa_is_gles(ctx) && format == internalFormat) {
Also, I think the check here should be ctx->API == API_OPENGLES2. We don't
want to do this in GLES 1.1.
> if (type == GL_FLOAT) {
> texObj->_IsFloat = GL_TRUE;
> internalFormat = adjust_for_oes_float_texture(format, type);
> } else if (type == GL_HALF_FLOAT_OES || type == GL_HALF_FLOAT) {
> texObj->_IsHalfFloat = GL_TRUE;
> internalFormat = adjust_for_oes_float_texture(format, type);
> }
> }
--
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
