On Wed, Feb 04 2015, Kenneth Graunke wrote: > The cache will need to be much larger than 1024 entries - perhaps by an > order of magnitude.
Thanks for the feedback. I had meant to add a comment next to that 1024 in the code along the lines of "This value was chosen arbitrarily. An appropriate value will need to be found with testing." > We should respect $XDG_CACHE_HOME from the XDG base directory spec: > http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html > > Also, the snprintf makes me a bit nervous See patch 5/7. It fixes both of these problems. (My apologies for setting you up to review code that was replaced later in the series---but I'm always a little hesitant to squash things to much when only some of the code is actually mine). > Typo: unnecessary compile (missing 'n'). Also, */ goes on its own > line. Thanks. I've fixed both of these now. -Carl
pgpRw1mcWIDW5.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
