On Mon, Jan 26, 2015 at 2:21 PM, Eric Anholt <e...@anholt.net> wrote: > I just notied: When do I need to all nir_metadata_preserve()? I didn't > in my pass.
It dirties all the metadata (topologically-sorted block indices, dominance info, liveness info, etc.) except the stuff you tell it to preserve via the flags. You're supposed to call it after any pass where you mutate the IR. We should probably fix that... when you do stuff that mutates the instructions but doesn't mess with the basic blocks, you can just pass in nir_metadata_block_index | nir_metadata_dominance like Jason did here since right now those are the only things that depend only on the block structure. > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
