On Thursday, January 15, 2015 01:06:24 PM Jason Ekstrand wrote: > On Thu, Jan 15, 2015 at 1:01 PM, Eric Anholt <e...@anholt.net> wrote: > > > Jason Ekstrand <ja...@jlekstrand.net> writes: > > > > > --- > > > src/glsl/nir/nir.h | 2 +- > > > src/mesa/Makefile.sources | 2 - > > > src/mesa/drivers/dri/i965/intel_fbo.c | 2 +- > > > src/mesa/main/set.c | 346 > > ---------------------------------- > > > src/mesa/main/set.h | 94 --------- > > > src/mesa/main/shared.c | 2 +- > > > src/mesa/main/syncobj.c | 2 +- > > > src/mesa/main/vdpau.c | 2 +- > > > src/util/Makefile.sources | 2 + > > > src/util/hash_set.c | 346 > > ++++++++++++++++++++++++++++++++++ > > > src/util/hash_set.h | 94 +++++++++ > > > 11 files changed, 447 insertions(+), 447 deletions(-) > > > delete mode 100644 src/mesa/main/set.c > > > delete mode 100644 src/mesa/main/set.h > > > create mode 100644 src/util/hash_set.c > > > create mode 100644 src/util/hash_set.h > > > > I'm not a fan of renaming the files to hash_set.[ch]. The name of the > > datatype is "set", the function names are "set", and people call these > > things "sets". > > > > I'm not going to block based on that, but I'd rather see the filenames > > retained. Other than this, the series is: > > > > Reviewed-by: Eric Anholt <e...@anholt.net> > > > > Sure, I can can the rename. I thought about renaming the whole thing to > hash_set but didn't want to deal with the churn. I'll just switch it to > set.h and set.c before pushing.
Thanks, I prefer set.[ch] as well. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
