On Mon, Dec 01, 2014 at 10:23:31AM -0800, Matt Turner wrote: > On Mon, Dec 1, 2014 at 4:59 AM, Juha-Pekka Heikkila > <juhapekka.heikk...@gmail.com> wrote: > > Declare local tables constant. Also added extra '32' at end of > > "width_for_reg" to be future proof, cvt function which give > > indexes to access here could already give index to reach place > > number five now containing '32'. > > I don't see any evidence of 32 being a valid width. We don't have a > macro for it in brw_defines.h. Damien's tool [1] also says 32 isn't > valid.
Given that a half byte (apparently this part of the docs aren't fond of the word nibble) isn't a real datatype, I doubt 32 will ever be valid. > > [1] http://damien.lespiau.name/intel/gen_regions.html > > With that removed (or justified), > > Reviewed-by: Matt Turner <matts...@gmail.com> Same answer from me, With that removed (or justified), Reviewed-by: Ben Widawsky <b...@bwidawsk.net> > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
