> I'd probably put the version checking logic into a helper function, but > not a big deal.
Any suggestion to where put such helper? I'm searching but I'm not confident where's the best place to put it so that it can be used everywhere. Would src/mesa/main/version.[ch] be ok? This would at least be good enough for st/glx and st/wgl. Like: boolean _mesa_is_valid_opengl_version(int major, int minor) boolean _mesa_is_valid_opengl_es_version() Jose ________________________________________ From: Brian Paul <bri...@vmware.com> Sent: 14 November 2014 19:37 To: Jose Fonseca; mesa-dev@lists.freedesktop.org Subject: Re: [PATCH 2/2] st/wgl: Implement WGL_EXT_create_context_es/es2_profile. On 11/14/2014 12:13 PM, Jose Fonseca wrote: > Thanks for the review. > >> I'd probably put the version checking logic into a helper function, but > not a big deal. > > Good idea. I'll do that in a follow on patch. > >> It looks like we're not doing as extensive version checking in the glx code. > > It's actually the same amount of checking. But on GLX we somehow need to > return a different error for ES profiles to make piglit happy. Ah right, I was looking at the unpatched code. -Brian _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
