Yes, you're right. I'll fix that. Marek
On Mon, Nov 10, 2014 at 12:53 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: > On Sun, Nov 9, 2014 at 6:39 PM, Marek Olšák <mar...@gmail.com> wrote: >> >> diff --git a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> index f227559..6df0c47 100644 >> --- a/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> +++ b/src/gallium/drivers/nouveau/nv30/nv30_state_validate.c >> @@ -254,11 +254,11 @@ nv30_validate_viewport(struct nv30_context *nv30) >> PUSH_DATAf(push, vp->translate[0]); >> PUSH_DATAf(push, vp->translate[1]); >> PUSH_DATAf(push, vp->translate[2]); >> - PUSH_DATAf(push, vp->translate[3]); >> + PUSH_DATAf(push, 1.0f); > > > This should probably be 0.0f... or am I misunderstanding what this does? > >> >> PUSH_DATAf(push, vp->scale[0]); >> PUSH_DATAf(push, vp->scale[1]); >> PUSH_DATAf(push, vp->scale[2]); >> - PUSH_DATAf(push, vp->scale[3]); >> + PUSH_DATAf(push, 1.0f); >> BEGIN_NV04(push, NV30_3D(DEPTH_RANGE_NEAR), 2); >> PUSH_DATAf(push, vp->translate[2] - fabsf(vp->scale[2])); >> PUSH_DATAf(push, vp->translate[2] + fabsf(vp->scale[2])); > > > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
