On Mon, Sep 29, 2014 at 12:30 PM, Liu, Leo <leo....@amd.com> wrote: > Hi Emil, > > Thanks for the explanation. > V4 has been sent, please review.
V4 is: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com> > > Thanks, > Leo > >>-----Original Message----- >>From: Emil Velikov [mailto:emil.l.veli...@gmail.com] >>Sent: Monday, September 29, 2014 12:27 PM >>To: Liu, Leo >>Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian >>Subject: Re: [Mesa-dev] [PATCH v3 2/6] st/va: skeleton VAAPI state tracker >> >>Hi Leo, >> >>[...] >>>>It seems that you've dropped the sym file. Is that intentional, can we >>>>get it back please ? >>>> >>> I will get it back. >>> What's the purpose of this sym file? Thanks. >>> >>It can be used for two purposes - version/tag exported symbols, manager >>exported/private symbols. >>We use the latter, otherwise our libraries will export functions which they >>should >>not. Mostly llvm symbols plus a few other which cannot be easily fixed >>otherwise. >> >>>>> +dnl Directory for VA libs >>>>> + >>>>> +AC_ARG_WITH([va-libdir], >>>>> + [AS_HELP_STRING([--with-va-libdir=DIR], >>>>> + [directory for the VA libraries @<:@default=`pkg-config >>>>> +libva -- >>>>variable=driverdir`@:>@])], >>>>> + [VA_LIB_INSTALL_DIR="$withval"], >>>>> + [VA_LIB_INSTALL_DIR=`pkg-config libva --variable=driverdir`]) >>>>> +AC_SUBST([VA_LIB_INSTALL_DIR]) >>>>> + >>>>The above hunk has silently changed since v2 and I'm not sure this one is >>better. >>>>Also there is a discussion about mesa's use of the above pkg-config to >>>>set the destination/install dir. I'll amend mesa at a later stage once >>>>a decision is made :) >>>> >>> So, Can I just keep it like this for now? >>> >>I meant the complete opposite, but don't bother. Most likely I'll redo this >>in a day >>or so. >> >>-Emil > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
