On Sun, 28 Sep 2014 13:00:47 -0400 Ilia Mirkin <imir...@alum.mit.edu> wrote:
> This reverts commit bbe6f7f865cd4316b5f885507ee0b128a20686eb. > > This change broke the usual assumption that setting a prefix will cause > files to be installed into that prefix. Restore that assumption before > people's system installs are accidentally overwritten, and everyone > starts having to add a --with-libvdpau-dir as a hack to work around this. > > Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> > Cc: Christian König <deathsim...@vodafone.de> > Cc: Alexandre Demers <alexandre.f.dem...@gmail.com> > Cc: Matt Turner <matts...@gmail.com> > Cc: Emil Velikov <emil.l.veli...@gmail.com> > --- > > Emil and I had a discussion about this on IRC but he didn't seem to > agree. However I think that this behavior is as broken as opening up > ld.so.conf, grabbing the first dir from that and using that as the > installation libdir. (Which I think everyone can agree is ridiculous.) > > Setting a prefix should cause things to be installed into that prefix. This is > how every other autoconf-using package behaves. > > As a side-note, using --with-module-dir as an installation destination is a > little crazy, but... I don't have the energy to fight that one. > > configure.ac | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Hi, so do I understand correctly, that assuming there is a system libvdpau installed but not another one in the $prefix, then Emil wants the system libvdpau to automatically discover the backends from $prefix? (Not literally, but with an equivalent effect.) If so, I would find that strange. A system library finding modules automatically from inside a $prefix is certainly unexpected. One uses a separate $prefix to exactly avoid that. Yet, from the IRC and this discussion here, it sounds like the reason to make the original patch, except it's just the other way around: cannot make system libvdpau go look in arbitrary $prefixes, so install into the system paths instead. If that was not the reason, then I completely missed it, sorry. FWIW, I agree with Ilia: 'make install' should never attempt to write outside of the given $prefix (or DESTDIR, whatwasit). It didn't even cross my mind before that some build might actually try writing to system paths regardless (and then simply fail half-way through installing, leaving me with a broken $prefix). Thanks, pq _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
