On Sunday, August 31, 2014 11:33:58 AM Matt Turner wrote: > Despite the comment above the function claiming otherwise, the function > did not reswizzle sources, which would lead to bad code generation.
Perhaps expand this to something like: which lead to incorrect code generation since commit 04895f5c601b240df547739da786b7c2b65bdd1e, which began claiming we could do such swizzling when we could not. When I first read "bad code generation", I thought you meant suboptimal code, not broken code :) > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82932 > --- > src/mesa/drivers/dri/i965/brw_vec4.cpp | 32 +++++++++++++++++++++++--------- > src/mesa/drivers/dri/i965/brw_vec4.h | 4 ++-- > 2 files changed, 25 insertions(+), 11 deletions(-) Looks okay to me. Thanks! Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
