Brian, Did you want to look over these or should I try and find someone else to review them? I'm most concerned with the 565 and 5551 patches since those touch corners of mesa with which I am very unfamiliar. --Jason
On Sat, Aug 23, 2014 at 3:27 PM, Jason Ekstrand <ja...@jlekstrand.net> wrote: > One more note: I tested these on i965, llvmpipe, and swrast on both my > laptop and my desktop. No changes on i965. A couple changes on llvmpipe > on my desktop which I can't reproduce on my laptop. I think that's my > desktop being funny. There seems to be one little issue still on swrast > with RGB4 renderbuffers (which get mapped to 565). Unfortunately, I > haven't been able to track that down. It's probably some place where the > format conversion code is repeated. > --Jason > > > On Sat, Aug 23, 2014 at 3:23 PM, Jason Ekstrand <ja...@jlekstrand.net> > wrote: > >> I needed a break from the i965 compiler backend, so I wrote some more >> format conversion patches. A lot of these are bug fixes or stand-alones. >> However, the last three require all the previous ones. >> >> Jason Ekstrand (8): >> main/format_util: Fix a bug in one of the format helper functions >> main: Fix packing/unpacking of MESA_FORMAT_R5G6B5_UNORM >> main/colormac: Remove an unused macro >> main: Fix A1R5G5B5 packing/unpacking >> mesa/format_utils: Prefix and expose the conversion helper functions >> main: Autogenerate most of format_pack.c >> MAYBEREVERT: Fill X components with 1 >> main: Autogenerate format_unpack.c >> >> src/mesa/Makefile.am | 18 + >> src/mesa/Makefile.sources | 4 +- >> src/mesa/main/colormac.h | 3 - >> src/mesa/main/format_convert.py | 72 + >> src/mesa/main/format_pack.c | 18 +- >> src/mesa/main/format_pack.c.mako | 900 ++++++++ >> src/mesa/main/format_unpack.c | 4329 >> ------------------------------------ >> src/mesa/main/format_unpack.c.mako | 883 ++++++++ >> src/mesa/main/format_utils.c | 215 +- >> src/mesa/main/format_utils.h | 105 + >> src/mesa/main/formats.c | 14 +- >> src/mesa/main/run_mako.py | 7 + >> src/mesa/main/texstore.c | 2 +- >> src/mesa/swrast/s_texfetch_tmp.h | 16 +- >> 14 files changed, 2061 insertions(+), 4525 deletions(-) >> create mode 100644 src/mesa/main/format_convert.py >> create mode 100644 src/mesa/main/format_pack.c.mako >> delete mode 100644 src/mesa/main/format_unpack.c >> create mode 100644 src/mesa/main/format_unpack.c.mako >> create mode 100644 src/mesa/main/run_mako.py >> >> -- >> 2.1.0 >> >> >
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev