On Monday, September 01, 2014 09:44:31 AM Jordan Justen wrote: > All fields were migrated from brw_wm_prog_key. In future updates, we can move > these FS specific fields back into brw_wm_prog_key.
We should just put things in the right place to begin with.
> struct brw_wm_prog_key {
> - uint8_t iz_lookup;
> - GLuint stats_wm:1;
> - GLuint flat_shade:1;
> - GLuint persample_shading:1;
> - GLuint persample_2x:1;
> - GLuint nr_color_regions:5;
> - GLuint replicate_alpha:1;
FS only
> - GLuint render_to_fbo:1;
Probably FS only
> - GLuint clamp_fragment_color:1;
> - GLuint compute_pos_offset:1;
> - GLuint compute_sample_id:1;
> - GLuint line_aa:2;
> - GLuint high_quality_derivatives:1;
FS only
> - GLushort drawable_height;
Probably FS only
> - GLbitfield64 input_slots_valid;
Not sure.
> - GLuint program_string_id:32;
Necessary for compute.
> - GLenum alpha_test_func; /* < For Gen4/5 MRT alpha test */
> - float alpha_test_ref;
FS only.
> - struct brw_sampler_prog_key_data tex;
Shared.
> + struct brw_scalar_prog_key base;
> };
>
> /**
So, 90% of them are FS only...moving those out of the FS specific program key
seems like the wrong thing to do.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
