https://bugs.freedesktop.org/show_bug.cgi?id=82472
Priority: medium
Bug ID: 82472
Keywords: bisected, regression
CC: cwo...@cworth.org, i...@freedesktop.org
Assignee: mesa-dev@lists.freedesktop.org
Summary: piglit 16385-consecutive-chars regression
Severity: normal
Classification: Unclassified
OS: Linux (All)
Reporter: v...@freedesktop.org
Hardware: x86-64 (AMD64)
Status: NEW
Version: git
Component: Mesa core
Product: Mesa
mesa: 23d782067ae834ad53522b46638ea21c62e94ca3 (master 10.3.0-devel)
$ ./bin/glslparsertest tests/glslparsertest/glsl2/16385-consecutive-chars.frag
pass 1.10
Aborted (core dumped)
04e40fd337a244ee77ef9553985e9398ff0344af is the first bad commit
commit 04e40fd337a244ee77ef9553985e9398ff0344af
Author: Carl Worth <cwo...@cworth.org>
Date: Tue Jul 1 16:31:07 2014 -0700
glsl/glcpp: Treat CR+LF pair as a single newline
The GLSL specification says that either carriage-return, line-feed, or both
together can be used to terminate lines. Further, it says that when used
together, the pair of terminators shall be interpreted as a single line.
This final requirement has not been respected by glcpp up until now, (it
has
been emitting two newlines for every CR+LF pair).
Here, we fix the lexer by using a regular expression for NEWLINE that eats
up both "\r\n" (or even "\n\r") if possible before also considering a
single
'\n' or a single '\r' as a line terminator.
Before this commit, the test results are as follows:
\r: 135/143 tests pass
\r\n: 4/143 tests pass
\n\r: 4/143 tests pass
After this commit, the test results are as follows:
\r: 135/143 tests pass
\r\n: 140/143 tests pass
\n\r: 139/143 tests pass
So, obviously, a dramatic improvement.
Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
:040000 040000 1f73084ed2a50bab0d7561b087f8c9ae3a480322
e696705124b77a67588c80b91c9e68c56a2586b9 M src
bisect run success
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
