On 05/08/14 00:52, Emil Velikov wrote:
> On 05/08/14 00:36, srol...@vmware.com wrote:
>> From: Roland Scheidegger <srol...@vmware.com>
>>
>> Build system so I've no idea what I'm doing but this looks similar to other
>> build fixes...
>> ---
>>  src/gallium/targets/dri/SConscript | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/gallium/targets/dri/SConscript 
>> b/src/gallium/targets/dri/SConscript
>> index 7c567c3..f7d793b 100644
>> --- a/src/gallium/targets/dri/SConscript
>> +++ b/src/gallium/targets/dri/SConscript
>> @@ -7,6 +7,7 @@ if env['suncc']:
>>      Return()
>>  
>>  env.Append(CPPPATH = [
>> +    '#/src',
> Please drop this. We're talking about linking issues not compilation.
> 
>>      '#/src/loader',
>>      '#/src/mapi',
>>      '#/src/mesa',
>> @@ -33,6 +34,7 @@ env.Append(CPPDEFINES = [
>>  ])
>>  
>>  env.Prepend(LIBS = [
>> +    mesautil,
> And feel free to move this one above the mesa lib.
>>      st_dri,
>>      svgadrm,
>>      svga,
>>
> With those fixed the patch is
> Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>
> 
Interesting... libEGL.so has a few undef reffs to mapi_*. Not sure if these
are there by design or it's a bug :\

For reference in the automake build, only the dri modules have undef reffs -
_glapi_*.

Anyone working with/using scons might want to add -Wl,-no-undefined + the
version-scripts we use with automake :)

-Emil


_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reply via email to