On 23/11/13 01:06, Alexandre Demers wrote: > Moving LT_INIT after setting completely (AM_)C(XX)FLAGS and LDFLAGS. > LT_INIT needs them as they are expected to be used all along > the compilation when the macro runs its tests to determine among other > things the host type. > > For info, see > http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html > > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50754 > > Signed-off-by: Alexandre Demers <alexandre.f.dem...@gmail.com> > Tested-by: Tapani Palli <lem...@gmail.com> Thanks for the patch Alexandre, it looks good IMHO. Reviewed-by: Emil Velikov <emil.l.veli...@gmail.com>
I will give it a couple of days in case someone wants to comment in case they have not noticed it before and then push it to master. -Emil > --- > configure.ac | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/configure.ac b/configure.ac > index fb16338..d41595d 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -51,9 +51,6 @@ AX_PYTHON_MODULE([libxml2], [needed]) > AC_PROG_SED > AC_PROG_MKDIR_P > > -LT_PREREQ([2.2]) > -LT_INIT([disable-static]) > - > AX_PROG_BISON([], > AS_IF([test ! -f "$srcdir/src/glsl/glcpp/glcpp-parse.c"], > [AC_MSG_ERROR([bison not found - unable to compile > glcpp-parse.y])])) > @@ -1956,6 +1953,14 @@ dnl Add user CFLAGS and CXXFLAGS > CFLAGS="$CFLAGS $USER_CFLAGS" > CXXFLAGS="$CXXFLAGS $USER_CXXFLAGS" > > +dnl > +dnl LT_INIT adds tests to determine host based on some variables like > (AM_)C(XX)FLAGS and (AM_)LDFLAGS. > +dnl They need to be set before calling LT_INIT so the macro can configure > things correctly when cross_compiling. > +dnl This will allow --enable-xx-bit to work as expected. > +dnl > +LT_PREREQ([2.2]) > +LT_INIT([disable-static]) > + > dnl Substitute the config > AC_CONFIG_FILES([Makefile > src/Makefile > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
