On Tue, Jul 29, 2014 at 04:29:05PM -0700, Kenneth Graunke wrote: > A while back, I wrote a patch to skip border color upload, and got > annoyed by having to write it twice - once for the Gen4-6 code, and > once for Gen7+. So I decided to clean that up. > > 23 patches and a bug fix later, I've unified the code, deleting > gen7_sampler_state.c entirely. There's now one copy of the logic to > upload sampler state tables, and one copy of the logic that decides > what values to program. Packet assembly now uses bitshifts instead > of structures, which is more consistent with the surface state code. > > Tested with Piglit on Crestline, Sandybridge, and Haswell: no regressions. > The series is available as the 'sampler-cleanups' branch of my tree.
I found a few minor nits but patches 1-22 are: Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com> It looks a lot nicer, and also safer now! > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
