On Friday, July 18, 2014 06:25:25 PM Jason Ekstrand wrote: > Since intel is always going to be little-endian, > GL_UNSIGNED_INT_8_8_8_8_REV is the same as GL_BYTE for RGBA and BGRA
I think you meant GL_UNSIGNED_BYTE.
Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
> textures, so the same acceleration code will work. We might as well use
> it.
> ---
> src/mesa/drivers/dri/i965/intel_tex_subimage.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> index c73cf10..875190f 100644
> --- a/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> +++ b/src/mesa/drivers/dri/i965/intel_tex_subimage.c
> @@ -560,7 +560,7 @@ intel_texsubimage_tiled_memcpy(struct gl_context * ctx,
> * we need tests.
> */
> if (!brw->has_llc ||
> - type != GL_UNSIGNED_BYTE ||
> + !(type == GL_UNSIGNED_BYTE || type == GL_UNSIGNED_INT_8_8_8_8_REV) ||
> texImage->TexObject->Target != GL_TEXTURE_2D ||
> pixels == NULL ||
> _mesa_is_bufferobj(packing->BufferObj) ||
> @@ -573,6 +573,10 @@ intel_texsubimage_tiled_memcpy(struct gl_context * ctx,
> packing->Invert)
> return false;
>
> + if (type == GL_UNSIGNED_INT_8_8_8_8_REV &&
> + !(format == GL_RGBA || format == GL_BGRA))
> + return false; /* Invalid type/format combination */
> +
> if ((texImage->TexFormat == MESA_FORMAT_L_UNORM8 && format ==
> GL_LUMINANCE) ||
> (texImage->TexFormat == MESA_FORMAT_A_UNORM8 && format == GL_ALPHA)) {
> cpp = 1;
>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
