On Tuesday, July 22, 2014 11:53:16 AM Pohjolainen, Topi wrote: > On Fri, Jul 18, 2014 at 02:16:39PM -0700, Jordan Justen wrote: > > We will program the gen6 hiz depth state differently to enable layered > > rendering on gen6. > > > > v2: > > * Remove unneeded gen6_emit_depthbuffer as suggested by Topi > > > > Signed-off-by: Jordan Justen <jordan.l.jus...@intel.com> > > Compared side by side with brw_emit_depth_stencil_hiz() and looks identical. > I was hoping we could start merging gen6-gen8 surface state logic as there > seems to be quite a bit of overlap. This change adds even more but I think > it is still a step forward as now gen6 is closer to gen7/8. > Proper refactoring between different generations requires some more thinking > and possibly some trial-and-error too. This patch will make that work easier > in my opinion. > > Reviewed-by: Topi Pohjolainen <topi.pohjolai...@intel.com>
I'm really glad to see this split - I did something similar a long time ago, but it conflicted with Paul's other works, so I never landed it. Either that or I never quite got it working. :) That said, you really should clean up both halves of the split: delete the Gen6 checks from brw_emit_depth_stencil_hiz, and delete the Gen4-5 checks from gen6_emit_depth_stencil_hiz. You could do that here, or in a patch or two immediately following the copy-and-paste. --Ken
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
