On Tue, Jul 22, 2014 at 12:36:33AM +0200, Grigori Goronzy wrote:
> On 17.07.2014 21:24, Tom Stellard wrote:
> > On Thu, Jul 17, 2014 at 06:44:25PM +0200, Grigori Goronzy wrote:
> >> Accuracy of some operations was recently improved in the R600 backend,
> >> at the cost of slower code. This is required for compute shaders,
> >> but not for graphics shaders. Add unsafe-fp-math hint to make LLVM
> >> generate faster but possibly less accurate code.
> >>
> >> Piglit didn't indicate any regressions.
> >
> > Both patches are:
> > Reviewed-by: Tom Stellard <thomas.stell...@amd.com>
> >
>
> Can you please commit the patches for me? My account request is still
> pending.
>
I just pushed these, thanks!
-Tom
> Grigori
>
> >> ---
> >> src/gallium/drivers/radeon/radeon_llvm_emit.c | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
> >> b/src/gallium/drivers/radeon/radeon_llvm_emit.c
> >> index 1b17dd4..171ccaa 100644
> >> --- a/src/gallium/drivers/radeon/radeon_llvm_emit.c
> >> +++ b/src/gallium/drivers/radeon/radeon_llvm_emit.c
> >> @@ -26,6 +26,7 @@
> >> #include "radeon_llvm_emit.h"
> >> #include "radeon_elf_util.h"
> >> #include "util/u_memory.h"
> >> +#include "pipe/p_shader_tokens.h"
> >>
> >> #include <llvm-c/Target.h>
> >> #include <llvm-c/TargetMachine.h>
> >> @@ -50,6 +51,10 @@ void radeon_llvm_shader_type(LLVMValueRef F, unsigned
> >> type)
> >> sprintf(Str, "%1d", type);
> >>
> >> LLVMAddTargetDependentFunctionAttr(F, "ShaderType", Str);
> >> +
> >> + if (type != TGSI_PROCESSOR_COMPUTE) {
> >> + LLVMAddTargetDependentFunctionAttr(F, "unsafe-fp-math", "true");
> >> + }
> >> }
> >>
> >> static void init_r600_target() {
> >> --
> >> 1.8.3.2
> >>
> >> _______________________________________________
> >> mesa-dev mailing list
> >> mesa-dev@lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> >
>
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
