On Fri, Jul 18, 2014 at 4:33 PM, Matt Turner <matts...@gmail.com> wrote:
> On Mon, Jul 14, 2014 at 3:48 PM, Ian Romanick <i...@freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.roman...@intel.com>
>>
>> No change Valgrind massif results for a trimmed apitrace of dota2.
>>
>> Signed-off-by: Ian Romanick <ian.d.roman...@intel.com>
>> ---
>> src/glsl/ir.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/glsl/ir.h b/src/glsl/ir.h
>> index ee42857..5c565ff 100644
>> --- a/src/glsl/ir.h
>> +++ b/src/glsl/ir.h
>> @@ -88,12 +88,13 @@ enum ir_node_type {
>> */
>> class ir_instruction : public exec_node {
>> private:
>> - enum ir_node_type ir_type;
>
> Mark this with the packed attribute and drop the previous patch.
Oh, you're doing it this way because MSVC isn't going to support the
packed attribute, and you want to store stuff in the padding, which is
sized by knowledge of how the struct is going to be laid out.
Like you said, the last patches are contentious. If we don't store
things in the padding, we should definitely just mark this with
packed. If we do store things in the padding, I'm still not sure we
should worry about making it optimal on MSVC.
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
