"Pohjolainen, Topi" <topi.pohjolai...@intel.com> writes: > All the other state flags considered in _mesa_meta_begin() are > explicitly set as disabled. And having noticed that you > unconditionally disable dithering also in cleartexsubimage_using_fbo() > I'm wondering if I'm missing something.
My understanding is that _mesa_meta_begin is supposed to reset the state to the GL defaults and dithering is enabled by default in GL. If I were to set it to disabled then it would also affect things like _mesa_meta_GenerateMipmap which uses MESA_META_ALL. Presumably that function will currently either use dithering or not depending on whether the user has toggled the state. I think it makes sense for that function to always use dithering so this patch arguably fixes a bug with that function (and others). Thanks for the review. Regards, - Neil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
