Re: [Mesa-dev] [PATCH 1/2] i965: Don't enable SOL statistics during meta operations.

[Kenneth Graunke]

On Wednesday, July 02, 2014 09:08:04 PM Kristian Høgsberg wrote:
> On Tue, Jul 1, 2014 at 5:25 PM, Kenneth Graunke <kenn...@whitecape.org> 
wrote:
> > The GL_TRANSFORM_FEEDBACK_PRIMITIVES_WRITTEN counter is not supposed to
> > increment during glGenerateMipmap().  I don't think either counter is
> > supposed to increment during most meta operations, so simply turn off
> > statistics during those.
> >
> > Fixes one Piglit test:
> > spec/EXT_transform_feedback/generatemipmap prims_written
> >
> > Signed-off-by: Kenneth Graunke <kenn...@whitecape.org>
> > Cc: Iago Toral Quiroga <ito...@igalia.com>
> > Cc: Chris Forbes <chr...@ijw.co.nz>
> > ---
> >  src/mesa/drivers/dri/i965/gen7_sol_state.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/gen7_sol_state.c 
b/src/mesa/drivers/dri/i965/gen7_sol_state.c
> > index 558b525..eccd5a5 100644
> > --- a/src/mesa/drivers/dri/i965/gen7_sol_state.c
> > +++ b/src/mesa/drivers/dri/i965/gen7_sol_state.c
> > @@ -240,7 +240,8 @@ upload_3dstate_streamout(struct brw_context *brw, bool 
active,
> >      * in each stream via SO_PRIMITIVE_STORAGE_NEEDED.
> >      */
> >     dw1 |= SO_FUNCTION_ENABLE;
> > -   dw1 |= SO_STATISTICS_ENABLE;
> > +   if (!brw->meta_in_progress)
> > +      dw1 |= SO_STATISTICS_ENABLE;
> >
> >     if (active) {
> >        int urb_entry_read_offset = 0;
> 
> Do we need to add BRW_NEW_META_IN_PROGRESS to gen7_sol_state.dirty.brw?
> 
> Kristian

Eheheh...just keeping you on your toes...or...something.

Thanks, fixed in v2 :)

signature.asc
Description: This is a digitally signed message part.

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev