[Mesa-dev] [PATCH 11/23] glsl/glcpp: Don't use start-condition stack when switching to/from

[Carl Worth]

This commit does not cause any behavioral change for any valid program. Prior
to entering the <DEFINE> start condition, the only valid start condition is
<INITIAL>, so whether pushing/popping <DEFINE> onto the stack or explicit
returning to <INITIAL> is equivalent.

The reason for this change is that we are planning to soon add a start
condition for <HASH> with the following semantics:

        <HASH>: We just saw a directive-introducing '#'

        <DEFINE>: We just saw "#define" starting a directive

With these two start conditions in place, the only correct behavior is to
leave <DEFINE> by returning to <INITIAL>. But the old push/pop code would have
returned to the <HASH> start condition which would then cause an error when
the next directive-introducing '#' would be encountered.
---
 src/glsl/glcpp/glcpp-lex.l | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/glsl/glcpp/glcpp-lex.l b/src/glsl/glcpp/glcpp-lex.l
index 047a157..6c2da77 100644
--- a/src/glsl/glcpp/glcpp-lex.l
+++ b/src/glsl/glcpp/glcpp-lex.l
@@ -299,21 +299,21 @@ HEXADECIMAL_INTEGER       0[xX][0-9a-fA-F]+[uU]?
         */
 {HASH}define{HSPACE}+ {
        if (! parser->skipping) {
+               BEGIN DEFINE;
                yyextra->space_tokens = 0;
-               yy_push_state(DEFINE, yyscanner);
                RETURN_TOKEN (HASH_DEFINE);
        }
 }
 
        /* An identifier immediately followed by '(' */
 <DEFINE>{IDENTIFIER}/"(" {
-       yy_pop_state(yyscanner);
+       BEGIN INITIAL;
        RETURN_STRING_TOKEN (FUNC_IDENTIFIER);
 }
 
        /* An identifier not immediately followed by '(' */
 <DEFINE>{IDENTIFIER} {
-       yy_pop_state(yyscanner);
+       BEGIN INITIAL;
        RETURN_STRING_TOKEN (OBJ_IDENTIFIER);
 }
 
-- 
2.0.0

_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev