On 15/06/14 12:49, Giovanni Campagna wrote: > Hello all, > > This is the third attempt at swrast/llvmpipe support for DRM > drivers that don't have userspace support (qxl, cirrus, simpledrm, etc.) > > I hope I addressed all of Emil's comments. > Thanks for keeping up with my nit-picking Giovanni.
Pretty much everything looks great imho, just one silly question that slippe through the cracks: Why do you insist on using LIBGL env var when you're dealing with EGL/GBM ? IMHO the name is quite explanatory (meant/used by libGL), it may cause us some headaches if we try to go with "one variable that rules them all" approach. With that said, I would prefer (unless someone objects) if we push these after my long series of reshuffling the gallium targets has done in. I would gladly rebase this 3 patches over the 20+ one that I have. Thanks again. Emil > Giovanni > > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-dev > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev