On Friday, June 06, 2014 11:59:39 PM jfons...@vmware.com wrote:
> From: José Fonseca <jfons...@vmware.com>
>
> A recent ApiTrace change, that tries to dump more buffer state
> causes Mesa from my distro (10.1.4) to segfaults here.
>
> I haven't actually confirm this fixes it (I can't repro on master),
> but it seems a good idea to be defensive here anyway.
>
> Cc: "10.1 10.2" <mesa-sta...@lists.freedesktop.org>
> ---
> src/mesa/main/get.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index 267b5f2..9b56edb 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -1005,7 +1005,11 @@ find_custom_value(struct gl_context *ctx, const
struct value_desc *d, union valu
> break;
> /* GL_ARB_shader_atomic_counters */
> case GL_ATOMIC_COUNTER_BUFFER_BINDING:
> - v->value_int = ctx->AtomicBuffer->Name;
> + if (ctx->AtomicBuffer) {
> + v->value_int = ctx->AtomicBuffer->Name;
> + } else {
> + v->value_int = 0;
> + }
> break;
> /* GL_ARB_draw_indirect */
> case GL_DRAW_INDIRECT_BUFFER_BINDING:
> Thanks for fixing this, José! Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
