If memory serves me right, at least one debug wrapper does not return the base screen on failure. Audit all the helper drivers to be consistent throughout.
Signed-off-by: Emil Velikov <emil.l.veli...@gmail.com> --- src/gallium/auxiliary/target-helpers/inline_debug_helper.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h index 77c7cfd..6fe667d 100644 --- a/src/gallium/auxiliary/target-helpers/inline_debug_helper.h +++ b/src/gallium/auxiliary/target-helpers/inline_debug_helper.h @@ -26,6 +26,10 @@ #include "noop/noop_public.h" #endif +/* + * TODO: Audit the following *screen_create() - all of + * them should return the original screen on failuire. + */ static INLINE struct pipe_screen * debug_screen_wrap(struct pipe_screen *screen) { -- 1.9.2 _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev