On 05/05/2014 10:56 AM, Ian Romanick wrote: > From: Ian Romanick <ian.d.roman...@intel.com> > > In an earlier incarnation of populate_consumer_input_sets and > get_matching_input, the consumer_inputs_with_locations array was indexed > using the user-specified location. In that version, only user-defined > varyings were included in the array. > > In the current incarnation, the Mesa location is used to index the > array, and built-in varyings are included. > > This change fixes the unit test to exepect gl_ClipDistance in the array, > and it resizes the arrays to actually be big enough. It's just dumb > luck that the existing piglit tests use small enough locations to not > stomp the stack. :( > > Signed-off-by: Ian Romanick <ian.d.roman...@intel.com> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78258 > Cc: "10.2" <mesa-sta...@lists.freedesktop.org> > Cc: Vinson Lee <v...@freedesktop.org> > --- > src/glsl/link_varyings.cpp | 8 ++++---- > src/glsl/tests/varyings_test.cpp | 11 +++++------ > 2 files changed, 9 insertions(+), 10 deletions(-)
Looks reasonable to me. Presumably this is new code, so we don't need to backport beyond 10.2. Reviewed-by: Kenneth Graunke <kenn...@whitecape.org>
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
