Why would you need the whole query? A boolean if it should honor the currently set render condition sounds simpler and good enough to me.
Roland Am 04.05.2014 13:17, schrieb Marek Olšák: > I think the plan was to add "struct pipe_query *render_condition" to > pipe_blit_info. The value of NULL would mean the conditional rendering > is disabled. > > Marek > > On Sat, May 3, 2014 at 10:42 AM, Ilia Mirkin <imir...@alum.mit.edu> wrote: >> Hello, >> >> I've noticed that nv50 fails the latest version of the conditional >> rendering tests with glBlitFramebuffer. After looking at the changes >> to the test, I just adjusted the nouveau blit code to not turn off the >> current query. That fixed the failing test, but then the >> copyteximage/etc tests started failing. This is probably because >> pipe->blit is used for more than just the literal glBlitFramebuffer >> (like glCopyTexImage). >> >> I briefly tested with llvmpipe which exhibits the same failure as nv50 >> originally did, I'm guessing this is a general problem with gallium >> rather than being nv50- (or nouveau-) specific. >> >> So... what's the right way of dealing with this? Adding a bit to >> pipe_blit_info that indicates whether to leave the current query >> enabled? Or perhaps pipe_query reference? Something else? >> >> Thanks, >> >> -ilia >> >> P.S. The failing test is >> >> bin/nv_conditional_render-blitframebuffer -auto -fbo >> >> And the tests that start failing after changing the logic to not >> disable the query: >> >> bin/nv_conditional_render-copyteximage -auto >> bin/nv_conditional_render-copytexsubimage -auto >> bin/nv_conditional_render-generatemipmap -auto >> _______________________________________________ >> mesa-dev mailing list >> mesa-dev@lists.freedesktop.org >> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=F4msKE2WxRzA%2BwN%2B25muztFm5TSPwE8HKJfWfR2NgfY%3D%0A&m=P1%2BL030G%2FTyy%2FweQvmtDo86ewkfcsf3PU17P02pfSk8%3D%0A&s=9460e7e4d37d97dc73af65632a4f1674c0d6c485efc221257637e4a70b6b1983 > _______________________________________________ > mesa-dev mailing list > mesa-dev@lists.freedesktop.org > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/mesa-dev&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=F4msKE2WxRzA%2BwN%2B25muztFm5TSPwE8HKJfWfR2NgfY%3D%0A&m=P1%2BL030G%2FTyy%2FweQvmtDo86ewkfcsf3PU17P02pfSk8%3D%0A&s=9460e7e4d37d97dc73af65632a4f1674c0d6c485efc221257637e4a70b6b1983 > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
