On 04/17/2014 04:04 PM, Matt Turner wrote: > Using brw_imm_* creates a source with file=HW_REG, and the scheduler > inserts barrier dependencies when it sees HW_REG. None of these are > hardware-registers in the sense that they're special and scheduling > shouldn't touch them. A few of the modified cases already have HW_REGs > for other sources, so it won't allow extra flexibility in some cases. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++-- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-)
Both patches are: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> I do think we should mark the fs_reg(struct brw_reg) constructor 'explicit' to avoid this problem from creeping in again. There are other cases that don't consider HW_REG && fixed_hw_reg.file == IMM, so we really want to avoid doing that and just use IMM properly.
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
