On 04/14/2014 06:30 AM, Chia-I Wu wrote: > On Mon, Apr 14, 2014 at 1:04 PM, Kenneth Graunke <kenn...@whitecape.org> > wrote: >> We originally thought that GL 3.0 required GL_DEPTH_COMPONENT16 to map >> exactly to Z16. However, we misread the specification, thanks in part >> to LaTeX reordering the tables in the PDF. >> >> Page 180 of the GL 3.0 specification (glspec30.20080923.pdf) says: >> "[...] memory allocation per texture component is assigned by the GL to >> match the allocations listed in tables 3.16-3.18 as closely as possible. >> [...] >> >> Required Texture Formats >> [...] >> In addition, implementations are required to support the following sized >> internal formats. Requesting one of these internal formats for any >> texture type will allocate exactly the internal component sizes and >> types shown for that format in tables 3.16-3.17:" >> >> Notably, however, GL_DEPTH_COMPONENT16 does /not/ appear in table 3.16 >> or table 3.17. It appears in table 3.18, where the "exact" rule doesn't >> apply, and it falls back to the "closely as possible" rule. >> >> The confusing part is that the ordering of the tables in the PDF is: >> >> Table 3.16 (pages 182-184) >> Table 3.18 (bottom of page 184 to top of 185) >> Table 3.17 (page 185) >> >> Presumably, people saw table 3.16, then saw the table immediately >> following with DEPTH_COMPONENT* formats, and assumed it was 3.17. >> >> Based on a batch by Chia-I Wu, but without the driconf option to force > s/batch/patch/
Oops...fixed. > Both patches look good to me. Unless I overlooked your patch for > piglit, this is needed > > http://lists.freedesktop.org/archives/piglit/2014-February/009650.html > > to avoid a false regression. It would be great if you could review > and commit the piglit fix, as I do not have commit access. I committed it last night. Thanks!
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev