On 04/07/2014 02:44 PM, Emil Velikov wrote: > Parsing source files through build systems is never a good idea. > Especially when the issue can be resolved by adding a couple of > definitions to CPPFLAGS via the build system.
I've nothing against reverting the commit, but the log message is incorrect, xa_tracker.h is an installed header and thus must include the correct defines. (see my commit message). If we don't parse it using autoconf, we need to use sed or some other tool to fix the header. Otherwise Acked-by: Thomas Hellstrom <thellst...@vmware.com> /Thomas > > This reverts commit 61bedc3d6b08943f015f9d590c07a6af36c2a92c. > > Cc: Thomas Hellstrom <thellst...@vmware.com> > --- > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
