On 04/02/2014 01:05 AM, Chris Forbes wrote:
> None of the other 3-component 16bpc formats are directly supported, so
> they get promoted to XRGB equivalents. *Not* promoting RGB16F the same
> way makes texture views much more fiddly -- we don't want to have to do
> crazy copying behind the scenes.
>
> (with my other master + my experimental ARB_texture_view support) fixes
> the piglit test: `spec/ARB_texture_view/view compare 48bit formats`
>
> No regressions in gpu.tests on Haswell.
>
> Signed-off-by: Chris Forbes <chr...@ijw.co.nz>
> Reviewed-by: Ian Romanick <ian.d.roman...@intel.com>
> ---
> src/mesa/drivers/dri/i965/brw_surface_formats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> index c029d81..f203f52 100644
> --- a/src/mesa/drivers/dri/i965/brw_surface_formats.c
> +++ b/src/mesa/drivers/dri/i965/brw_surface_formats.c
> @@ -267,7 +267,7 @@ const struct surface_format_info surface_formats[] = {
> SF( x, x, x, x, x, x, Y, x, x, BRW_SURFACEFORMAT_R64G64B64_FLOAT)
> SF( Y, Y, x, x, x, x, x, x, x, BRW_SURFACEFORMAT_BC4_SNORM)
> SF( Y, Y, x, x, x, x, x, x, x, BRW_SURFACEFORMAT_BC5_SNORM)
> - SF(50, 50, x, x, x, x, 60, x, x, BRW_SURFACEFORMAT_R16G16B16_FLOAT)
> + SF( x, x, x, x, x, x, 60, x, x, BRW_SURFACEFORMAT_R16G16B16_FLOAT)
> SF( x, x, x, x, x, x, Y, x, x, BRW_SURFACEFORMAT_R16G16B16_UNORM)
> SF( x, x, x, x, x, x, Y, x, x, BRW_SURFACEFORMAT_R16G16B16_SNORM)
> SF( x, x, x, x, x, x, Y, x, x,
> BRW_SURFACEFORMAT_R16G16B16_SSCALED)
> Dropping support for this seems fine - Mesa will instead pick R16G16B16X16. I don't like making the table not reflect the docs though. I think you can achieve the same effect by changing: [MESA_FORMAT_RGB_FLOAT16] = BRW_SURFACEFORMAT_R16G16B16_FLOAT, to [MESA_FORMAT_RGB_FLOAT16] = 0, Would that work? --Ken
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
