The extension specifically mentions that it allows storing a query
result into a buffer without the GPU->CPU->GPU round-trip, but your
patch series contains that round-trip. If a driver cannot do it
without the round-trip, I don't think the extension should be exposed.
Adding an extension and only implementing a software fallback might be
useful for softpipe and llvmpipe, but people using hardware drivers
may see a significant drop in performance if this extension is used.
The same applies to ARB_clear_buffer_object, which is now advertised
without hardware support.
Marek
On Wed, Mar 19, 2014 at 10:30 PM, Rafal Mielniczuk
<rafal.mielnicz...@gmail.com> wrote:
> Hello,
>
> I have been playing around this extensions for a couple of days now,
> I got something working so I decided to send it for review :)
> I backed it up by piglit tests as well.
>
> Rafal
>
> Rafal Mielniczuk (8):
> glapi: Add xml infrastructure for ARB_query_buffer_object
> mesa: Add QueryBuffer to context
> mesa: Handle QUERY_RESULT_NO_WAIT in GetQueryObject{ui64}v
> mesa: Handle QUERY_BUFFER_BINDING in GetIntegerv
> mesa: Store GetQueryObject{ui64}v results in QueryBuffer if bound
> mesa: Fix typos in function names in queryobj
> mesa: Enable GL_ARG_query_buffer_object extension
> doc: mark GL_ARB_query_buffer_object as done
>
> docs/GL3.txt | 2 +-
> src/mapi/glapi/gen/ARB_query_buffer_object.xml | 18 +++++
> src/mapi/glapi/gen/Makefile.am | 1 +
> src/mapi/glapi/gen/gl_API.xml | 4 +
> src/mesa/main/bufferobj.c | 5 ++
> src/mesa/main/extensions.c | 1 +
> src/mesa/main/get.c | 4 +
> src/mesa/main/get_hash_params.py | 3 +
> src/mesa/main/mtypes.h | 2 +
> src/mesa/main/queryobj.c | 108
> ++++++++++++++++++++-----
> 10 files changed, 128 insertions(+), 20 deletions(-)
> create mode 100644 src/mapi/glapi/gen/ARB_query_buffer_object.xml
>
> --
> 1.9.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
