On 02/27/2014 12:30 AM, Ian Romanick wrote:
Did you piglit run this? I applied it on current master, and about 2,700 piglit tests assert.
Yes, at the time there were no piglit errors. Confirmed, the patch series breaks current master.
Not to mention it doesn't apply cleanly anymore anyway, new series required.
diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cppindex fb57707..4dc0482 100644 --- a/src/mesa/drivers/dri/i965/brw_vec4.cpp +++ b/src/mesa/drivers/dri/i965/brw_vec4.cpp @@ -411,6 +411,7 @@ vec4_visitor::pack_uniform_registers() /* Now, figure out a packing of the live uniform vectors into our * push constants. */ + assert(uniforms < uniform_array_size);All of the tests that I looked at (about a dozen) hit this assertion.
From tests/quick, with some grepping and processing on piglit result json directly, all those assert failures are this one.
*quick debugging build later* And all those asserts hit because uniforms == uniform_array_size. Fix is on the way. -- Petri Latvala _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
