On 13/02/14 13:53, Rob Clark wrote:
On Thu, Feb 13, 2014 at 8:39 AM, Emil Velikov <emil.l.veli...@gmail.com> wrote:
+if HAVE_MESA_LLVM
+# Mention a dummy pure C++ file to trigger generation of the $(LINK) variable
+nodist_EXTRA_libxatracker_la_SOURCES = dummy-cpp.cpp
Move before the HAVE_MESA_LLVM. It will translate to no-on if not required.
+
+libxatracker_la_LIBADD += $(LLVM_LIBS)
+libxatracker_la_LDFLAGS += $(LLVM_LDFLAGS)
+else
+# Mention a dummy pure C file to trigger generation of the $(LINK) variable
+nodist_EXTRA_libxatracker_la_SOURCES = dummy-c.c
+endif
Drop the else hunk
it does mean that you will always have a c++ dummy even if no llvm. I
don't really know if that is a problem or not, but this is why I'd
kept it similar to the other targets.
Two/thirds of the targets follow your approach, while the rest what I
have in mind. There was a recent patch for vdpau/r600 that reminded me
that this needs to stop :)
I'm not fussed if it's done here or not, as your patches focus another
topic.
-Emil
BR,
-R
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
