I've rebuilt my mesa/llvm stack with this patch instead of the alternative patches for fdo bug 70410. Everything seems satisfactory after I rebuilt llvm with --enable-shared. I haven't done full before/after piglit runs, but the partial run that I did is showing what looks like a proper amount of skipped/pass tests with very few failures. If you need, I can attempt full piglit runs to compare, but I don't see why this change would require it (programs used to bomb out immediately if the llvm linkage wasn't right).
This might make us a bit more vulnerable to issues due to changes in the LLVM versions installed on the system (as opposed to a functioning statically linked radeonsi and egl), but I'm not sure how big an issue that really is in practice. Tested-by: Aaron Watry <awa...@gmail.com> [1] https://bugs.freedesktop.org/show_bug.cgi?id=70410 On Tue, Feb 4, 2014 at 1:24 PM, Tom Stellard <t...@stellard.net> wrote: > From: Tom Stellard <thomas.stell...@amd.com> > > Linking with LLVM static libraries is easily broken by changes to > the llvm-config program or when LLVM adds, removes, or changes library > components. Keeping up with these changes requires a lot of maintanence > effort to keep the build working on the master and stable branches. > > Also, because of issues in the past LLVM static libraries, the release > manager is currently configuring with --with-llvm-shared-libs when > checking the build before release. Enabling shared libraries by > default would allow the release manager to run ./configure with > no arguments, and be reasonably confident that the build would succeed. > > CC: "10.1" <mesa-sta...@lists.freedesktop.org> > > --- > configure.ac | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 4da6c51..9568e7b 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -1528,11 +1528,11 @@ AC_ARG_ENABLE([gallium-llvm], > [enable_gallium_llvm="$enableval"], > [enable_gallium_llvm=auto]) > > -AC_ARG_WITH([llvm-shared-libs], > - [AS_HELP_STRING([--with-llvm-shared-libs], > - [link with LLVM shared libraries @<:@default=disabled@:>@])], > +AC_ARG_ENABLE([llvm-shared-libs], > + [AS_HELP_STRING([--enable-llvm-shared-libs], > + [link with LLVM shared libraries @<:@default=enabled@:>@])], > [], > - [with_llvm_shared_libs=no]) > + [with_llvm_shared_libs=yes]) > > AC_ARG_WITH([llvm-prefix], > [AS_HELP_STRING([--with-llvm-prefix], > -- > 1.8.1.4 > > _______________________________________________ > mesa-stable mailing list > mesa-sta...@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/mesa-stable _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
