Mark, I will do it if you send me a git link to your branch which merges cleanly and compiles successfully.
Marek On Sun, Jan 26, 2014 at 10:27 PM, Brian Paul <brian.e.p...@gmail.com> wrote: > On Sun, Jan 26, 2014 at 11:45 AM, Mark Mueller <markkmuel...@gmail.com> > wrote: >> >> >> >> >> On Fri, Jan 24, 2014 at 2:50 AM, Marek Olšák <mar...@gmail.com> wrote: >>> >>> On Thu, Jan 23, 2014 at 8:36 PM, Kenneth Graunke <kenn...@whitecape.org> >>> wrote: >>> > On 01/23/2014 11:19 AM, Mark Mueller wrote: >>> >> That works for sRGB, but what about other color spaces that may be >>> >> added in >>> >> the future? I'm fine with leaving that to another day and with using >>> >> the >>> >> _SRGB decoration, as you say. >>> > >>> > Oy. Let's not worry about things that hypothetically could be someday. >>> > We need to do what makes sense today. >>> >>> Yeah, let's commit this. We can discuss the other things later, >>> including if SRGB should be a type or a modifier. The series is >>> already pretty good. >>> >>> Marek >> >> >> I'm not sure if further acknowledgement is needed to push the series, >> but, either way, I'm not authorized to push these. > > > The series looks good to me too, but I'd also like to see the _UNORM8 -> > _SRGB suffix change in a follow-up patch. > > I tried applying the patch series to my local tree but it doesn't apply > cleanly. My recent "mesa: add missing ETC2_SRGB cases in formats.c" change, > and possibly others are at fault. Sorry. > > If you can rebase the series on top of master I can apply them, unless Marek > beats me to it (I'm in the midst of traveling today). > > -Brian > _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
