On 01/24/2014 10:51 PM, Chris Forbes wrote: > This series adds support for ARB_fragment_layer_viewport on i965 Gen7, in > core contexts [the same conditions as for ARB_viewport_array being exposed]. > > This is another tiny piece of GL4.3, allowing the GS- [or with > AMD_vertex_shader_*, VS- ] written values of gl_Layer and gl_ViewportIndex > to be read by the fragment shader. > > Note that there are a few oddities in the spec, which I've assumed hopefully > reasonable corrections for: > > - Dependencies section specifies that ARB_geometry_shader4 is required, but > should probably be 'geometry shaders are required', or perhaps 'GL 3.2 or > ARB_geometry_shader4 is required'. > - In the description of gl_Layer's behavior, there is a stray reference to > `gl_Value` which should be `gl_Layer`. > - The extension doesn't list a new define for shaders to test for presence. > I've assumed the usual pattern in 6/12.
From reading the code and spec, this looks good. Series is: Reviewed-by: Kenneth Graunke <kenn...@whitecape.org> But...are there Piglit tests for this?
signature.asc
Description: OpenPGP digital signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
