Kenneth Graunke <kenn...@whitecape.org> writes: > Broadwell requires software to specify QPitch in a bunch of packets, > so we decided to store it in the miptree. However, when I did that > refactoring, I missed a subtlety: the hardware expects QPitch to be > "in units of rows in the uncompressed surface". > > This is the value we originally compute. However, for compressed > surfaces, we then divided it by 4 (the block height), to obtain the > physical layout. This is no longer the QPitch Broadwell expects. > > So, store the original undivided value in mt->qpitch, but continue to > use the divided value in brw_miptree_layout_texture_array(). For > non-Broadwell platforms, this should have no impact at all. > > Helps fix Piglit's "getteximage-targets S3TC CUBE" test on Broadwell.
I'd noted this in the original review that led to saving qpitch in the miptree. :/ Reviewed-by: Eric Anholt <e...@anholt.net>
pgpsIxEVfULpV.pgp
Description: PGP signature
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
