On 22 January 2014 03:33, Timothy Arceri <t_arc...@yahoo.com.au> wrote:
> Previously the reason we needed is_array was because we used array_size ==
> NULL to
> represent both non-arrays and unsized arrays. Now that we use a non-NULL
> array_specifier to represent an unsized array, is_array is redundant.
>
> Signed-off-by: Timothy Arceri <t_arc...@yahoo.com.au>
> ---
> src/glsl/ast.h | 32 +++++++-------------------------
> src/glsl/ast_to_hir.cpp | 10 +++++-----
> src/glsl/ast_type.cpp | 6 ++----
> src/glsl/glsl_parser.yy | 30 +++++++++++++++---------------
> src/glsl/glsl_parser_extras.cpp | 15 ++++++---------
> 5 files changed, 35 insertions(+), 58 deletions(-)
>
When I try to build this patch I get the compile error:
CXX ast_to_hir.lo
../../src/glsl/ast_to_hir.cpp: In member function 'virtual ir_rvalue*
ast_declarator_list::hir(exec_list*, _mesa_glsl_parse_state*)':
../../src/glsl/ast_to_hir.cpp:2877:12: error: 'class ast_declaration' has
no member named 'is_array'
assert(!decl->is_array);
^
I'm guessing you missed this because you are building in release mode, so
asserts didn't get compiled. If that's the case, I'd like to encourage you
to do a debug build and double-check that piglit tests still pass. You can
do that by adding the "--enable-debug" option when you run ./autogen.sh.
With that fixed, the series is:
Reviewed-by: Paul Berry <stereotype...@gmail.com>
I'll try to push my patch "glsl: Simplify aggregate type inference to
prepare for ARB_arrays_of_arrays." within the next hour. Do you have
commit access to Mesa or would you like me to push the series for you?
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
