On Sun, Jan 19, 2014 at 7:56 PM, Michel Dänzer <mic...@daenzer.net> wrote:
> On Fre, 2014-01-17 at 03:47 -0800, Mark Mueller wrote: > > > > diff --git a/src/mesa/main/formats.h b/src/mesa/main/formats.h > > index 348d2f4..fb43c83 100644 > > --- a/src/mesa/main/formats.h > > +++ b/src/mesa/main/formats.h > > @@ -182,14 +182,14 @@ typedef enum > > MESA_FORMAT_RGB_UNORM8, > > > > /* Type P formats */ > > - MESA_FORMAT_RGB565, /* RRRR RGGG > GGGB BBBB */ > > - MESA_FORMAT_RGB565_REV, /* GGGB BBBB RRRR RGGG > */ > > - MESA_FORMAT_ARGB4444, /* AAAA RRRR GGGG BBBB > */ > > - MESA_FORMAT_ARGB4444_REV, /* GGGG BBBB AAAA RRRR > */ > > - MESA_FORMAT_RGBA5551, /* RRRR RGGG GGBB > BBBA */ > > - MESA_FORMAT_ARGB1555, /* ARRR RRGG GGGB BBBB > */ > > - MESA_FORMAT_ARGB1555_REV, /* GGGB BBBB ARRR RRGG > */ > > - MESA_FORMAT_AL44, /* AAAA LLLL > */ > > + MESA_FORMAT_B5G6R5_UNORM, /* BBBB BGGG GGGR RRRR */ > > + MESA_FORMAT_R5G6B5_UNORM, /* RRRR RGGG GGGB BBBB */ > > + MESA_FORMAT_B4G4R4A4_UNORM, /* BBBB GGGG RRRR AAAA */ > > + MESA_FORMAT_A4R4G4B4_UNORM, /* AAAA RRRR GGGG BBBB */ > > + MESA_FORMAT_A1B5G5R5_UNORM, /* ARRR RRGG GGGB BBBB */ > > + MESA_FORMAT_B5G5R5A1_UNORM, /* BBBB BGGG GGRR RRRA */ > > + MESA_FORMAT_A1R5G5B5_UNORM, /* ARRR RRGG GGGB BBBB */ > > + MESA_FORMAT_L4A4_UNORM, /* LLLL AAAA */ > > Please keep these comments aligned with the other comments describing > packed format layouts. (Please also don't remove the header comments > explaining the format of these comments) > Sorry, there were some fossilized tabs in there that I _had_ removed in an earlier patch but they came back like the night of the living dead. > > Also, why are you changing the component order in the comments for > these, but not for some other packed formats in the series? > > Last but not least, there are a few cases in the series where you're > defining a format as 'type A', when these comments clearly show that > they're packed formats. Please be careful. > > Unlike the 100's of global substitutions, all of the comments have to be done by hand and there were some stragglers that got through. With the major shift to a lot more P type formats, much of that has changed again. I should have a new patchset revision ready by tomorrow. Mark
_______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
