On 16/01/14 23:29, Kristian Høgsberg wrote: > On Sat, Jan 11, 2014 at 04:51:42PM -0500, Rob Clark wrote: >> > On Sat, Jan 11, 2014 at 11:54 AM, Emil Velikov <emil.l.veli...@gmail.com> >> > wrote: >>> > > This is an updated series of Rob's patches >>> > > >>> > > * The introduction of the util library is separated from the >>> > > de-duplication. >>> > > * Each commit targets individual part of mesa and it should >>> > > build/work regardless of build system/options. >>> > > * Handles a couple more cases of de-duplication. >>> > > * Hides the loader funcs so that they are not exported. >>> > > * Building platform_android, will correctly set the logger to >>> > > _eglLog(), which on itself is rapped around Androids (A)LOG. >>> > > * Non-pci devices support has been ripped out and is left at >>> > > the end of the series. >>> > > * automake and scons build tested, Android should after >>> > > correcting the following >>> > > defined(PIPE_OS_ANDROID) && !defined(_EGL_NO_DRM) >> > >> > Very cool, thanks for taking this and running with it. Especially the >> > other build systems which I have no clue about :-) >> > >> > I had a look at the patches, and they look good. So with the >> > disclaimer that I am certainly not expert on these parts, for the >> > series: >> > >> > Reviewed-by: Rob Clark <robdcl...@gmail.com> > I'm not familiar with the other build systems either, but aside for > those two issues I pointed out > > Reviewed-by: Kristian Høgsberg <k...@bitplanet.net> > > for the series. > Thanks gents.
Just pushed the series to master after addressing Kristian's comments. Stupidly I've created a loader-v4 branch as well, sorry about that. FWIW it seems that patchwork did not change the state of the following http://patchwork.freedesktop.org/patch/17793/ http://patchwork.freedesktop.org/patch/17784/ http://patchwork.freedesktop.org/patch/17788/ http://patchwork.freedesktop.org/patch/17792/ http://patchwork.freedesktop.org/patch/17811/ 1c5e296..bf70c23 master -> master Cheers, Emil _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev
